Skip to content

BUG: Validate PriorDict assignments #1116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Sanjays2402 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

BUG: Validate PriorDict assignments #1116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions bilby/core/prior/dict.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,14 @@ def __init__(self, dictionary=None, filename=None, conversion_function=None):
def __hash__(self):
return hash(str(self))

def __setitem__(self, key, value):
if not isinstance(value, (Prior, int, float, str, dict)):
raise TypeError(
"Unable to parse prior, bad entry: {} "
"= {} of type {}".format(key, value, type(value))
)
super().__setitem__(key, value)

@xp_wrap
def evaluate_constraints(self, sample, *, xp=None):
out_sample = self.conversion_function(sample)
Expand Down
5 changes: 5 additions & 0 deletions test/core/prior/dict_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,11 @@ def test_prior_set_has_correct_length(self):
def test_prior_set_has_expected_priors(self):
self.assertDictEqual(self.priors, dict(self.prior_set_from_dict))

def test_assignment_rejects_invalid_prior_value(self):
expected_error = "Unable to parse prior, bad entry"
with self.assertRaisesRegex(TypeError, expected_error):
self.prior_set_from_dict["Om0"] = np.array(0.30966)

def test_read_from_file(self):
expected = dict(
mass_1=bilby.core.prior.Constraint(
Expand Down