Repository navigation
feat: improve review recovery and migrate Codex roles - #91
Merged
Merged
Conversation
This was referenced Nov 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improve now constrains review reports to the frozen plan and retains reports and diagnostics when a turn fails or is cancelled. A confirmed interrupted implementation can reach independent review once the existing connection, stopped writers, exact candidate and required evidence have been verified; a failed or unknown review still cannot grant approval.
This addresses the requirements in #89:
The combined protocol fixtures preserve the reviewed report-recovery cases alongside the new model and generated-role assertions. Overlapping planning and workflow text retains both sets of requirements. Generated skills come from the canonical sources.
Verification
nix run .#sync-vendored-skills -- --checknix flake check --allow-import-from-derivationon the captured combined exporttests/plugin-portability.bashon the packaged combined runtime in a temporary HomeThe four newly bound English/Chinese previews at 1200 and 720 pixels are byte-identical to the previously approved images. Unchanged source audits and input facts were reused; the changed runtime/configuration/fixture combination received fresh checks.
Independent combined review returned APPROVE with no findings and complete scope, check and review coverage. Commit
b11737e6ba69053993166651742b4e4ff5ce0e5acontains exactly the reviewed tree47dd3484d70854cf308075385463470e45b3f585. GitHub Actionscheckandplugin-portabilityremain the final CI acceptance. Dedicated model-quality, quota-limit and proof-runtime experiments were not run; live model capabilities and newer Bend/Lean behavior are not claimed as tested.Closes #89.