Repository navigation
chore: bump MSRV to 1.85 and adopt Rust edition 2024 - #893
Merged
Merged
Conversation
- Bump the MSRV from 1.68.2 to 1.85.0 and switch glam and its in-repo tools to Rust edition 2024. - Remove the `abs`, `copysign` and `signum` wrappers from the internal `f32`/`f64` math backends. These standard library methods are available in `core` on the new MSRV, so the wrappers are no longer needed. - Reformat with the Rust 2024 style edition and bump the `tools/codegen` submodule so generated files use the matching rustfmt edition. Refs #850.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #850.
Bump glam's MSRV to 1.85.0 and adopt Rust edition 2024 before 1.0, which is the
last cheap opportunity to raise the MSRV or move editions.
Solution
Cargo.toml,clippy.toml,tools/ci/src/toolchain.rs, the CI workflow, and the MSRV docs(
README.md,CONTRIBUTING.md,src/lib.rs).unsafe_op_in_unsafe_fnin thesse2/neonintrinsic wrapper modules.abs,copysignandsignumwrappers from the internalf32/f64math backends. These standard library methods are available incoreon the new MSRV, so the wrappers and theirlibmcalls are no longerneeded; templates and generated code now call the methods directly.
tools/codegensubmodule (Format generated output with the Rust 2024 style edition glam-codegen#19) so generated files usethe matching rustfmt edition.
map_or(false, ..)clippy lints that the higherclippy.tomlMSRVnewly enables.
No new tests or benchmarks; the existing suite,
cargo run -p ci,cargo run -p ci -- lints, and the 1.85.0 MSRV check all pass.Checklist
cargo run -p cipasses.!.