Repository navigation
feat(cli): kates lists conformity under Deployment, and the deploy profile enables it - #435
Merged
Merged
Conversation
The root help listed `conformity` under Health & Status, next to the commands that report on the cluster right now. A conformity check holds a deployed cluster to the architecture it was meant to have, so it sits in Deployment now, after `deploy status`. The profile filter works line by line: a context with the topology profile still lists it, alone under Deployment, and one without it hides it as before.
A context limited to the deploy profile hid `conformity`, now listed under Deployment, because only topology enabled it. Checking a deployed cluster against its reference is deploy work as much as topology work, so both profiles enable it. The CLI Reference's profile table gains `conformity` in both rows (topology had been missing it), and the Conformity Checks chapter names both profiles.
bmscomp
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kateswith no arguments listedconformityunder Health & Status. A conformity check holds a deployed cluster to the architecture it was meant to have, so this PR moves it to Deployment, right afterdeploy status:The deploy profile enables it too. Only
topologyenabledconformity, so a context limited todeploywould have hidden it from the section it now lives in.command_profiles.gonow gives it{"deploy", "topology"}:KATES_PROFILES=deploy, the Deployment section listsconformity, andkates conformity lintruns.KATES_PROFILES=topology, it shows alone under Deployment.Docs
conformityin both rows. Thetopologyrow had been missing it since the command shipped.Checked locally:
go vet ./cmd,go test ./cmd/(includingTestProfileHelp),scripts/check-book-style.sh, and the built CLI's help with no profiles, withtopologyonly and withdeployonly.