Repository navigation
fix(kernel): cache the Python unpacked-bases regex - #606
Merged
Merged
Conversation
check:kernel-rules failed at member_fn_ref.rs:1082: python_unpacked_bases compiled a name-parameterized regex on every class header. The variable name is the only part that varies, so route the pattern through KernelResolver::cached_regex and compile each shape once. Rule scan: 3/3. python-self-call-not-import: 63/63. Golden dumps: 8/8. Full npm test: 957 files, 11,344 passed, 46 skipped, 0 failed.
![bompus-ai-review[bot]](https://avatars.githubusercontent.com/u/253635?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
member_fn_ref.rs:1082(python_unpacked_bases) compiled a name-parameterized regex on every class header, tripping thekernel-no-adhoc-name-regexrule that feat(kernel): port the remaining upstream resolution drift #587 added. The variable name is the only part that varies, so the pattern now goes throughKernelResolver::cached_regexand compiles each shape once.Why
check:kernel-rulesis red at0d4c48dc/73bac2e9, which failsnpm test's pretest for every checkout. This clears it.The four
gitignore-pattern-parityfailures were a separate, local-only issue: the installedignorewas 7.0.5 whilepackage.json/package-lock.jsonpin^7.0.14.npm ciresolves all four; no repository change.Tests
npm run check:kernel-rules: 3/3 pass; the scan is clean.python-self-call-not-import(includes the "method behind unpacked bases" case): 63/63.kernel-golden-dumps: 8/8, graph outputs unchanged.npm test: 957 files, 11,344 passed, 46 skipped, 0 failed (pretest and the gitignore suite included).README / docs
No user-visible surface changes; no README or site rows move.