Repository navigation
node-images: remove locking for kernel version - #154
Merged
Merged
Conversation
In the kernel version 7.0 had a regression, and we pinned the kernel to 6.19.14-200.fc43. See this issue for more details: bootc-dev#8 Signed-off-by: Alice Frosi <afrosi@redhat.com>
alicefr
changed the title
Reduce number of arguments passed to runAdd. Assisted-by: AI Signed-off-by: Alice Frosi <afrosi@redhat.com>
alicefr
force-pushed
the
solve-issue-8
branch
from
October 20, 2026 10:20
4294010 to
a39fada
Compare
The composefs backend in bootc requires UEFI boot because it reads the EFI variable LoaderDevicePartUUID to locate the ESP where boot entries are stored. Without UEFI firmware, bootc status fails with SystemNotUEFI. The ostree backend is unaffected since it reads boot entries from /sysroot/boot/loader/entries/ with no EFI dependency. This adds a --boot-firmware flag to cluster start and node add that passes --boot uefi to virt-install, switching from SeaBIOS to OVMF. The cluster container image now includes edk2-ovmf to provide the UEFI firmware files. Assisted-by: AI Signed-off-by: Alice Frosi <afrosi@redhat.com>
Bump VM memory to 2048MB when using UEFI because OVMF firmware consumes ~260MB, leaving less than kubeadm's 1700MB minimum with the default 1900MB. Assisted-by: AI Signed-off-by: Alice Frosi <afrosi@redhat.com>
alicefr
force-pushed
the
solve-issue-8
branch
from
October 20, 2026 10:25
a39fada to
1f82ea3
Compare
alicefr
changed the title
Johan-Liebert1
approved these changes
Oct 21, 2026
| } | ||
|
|
||
| func WithBootFirmware(firmware string) NodeOption { | ||
| return func(n *Node) error { |
Member
There was a problem hiding this comment.
Not blocking, but why return an error?
Collaborator
Author
There was a problem hiding this comment.
Because it is how the NodeOption is defined, see here. Functional Options Pattern is a known pattern in go. It is true that we don't return an error yet, but we could use it in the future to validate certain input
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the kernel version 7.0 had a regression, and we pinned the kernel to 6.19.14-200.fc43. See this issue for more details:
#8
Additionally, the new composefs based image requires the UEFI