Repository navigation
sysusers: Reject empty mandatory entry types - #2574
Conversation
eeef64e to
b81d1b5
Compare
|
I checked the failed jobs in run 38911232876. All 29 failing integration/upgrade/baseconfig/export jobs stop while building the test image: I tried rerunning the failed jobs, but GitHub requires repository admin rights. Could a maintainer rerun them once the ELN package is available, or advise whether this branch should be refreshed for an upstream CI fix? |
|
Reran failed jobs. Wait actually, @ddy314, could you rebase on main and push again. I forgot we had a CI fix for this issue |
Reject an empty quoted entry type instead of silently ignoring the directive. Empty optional fields continue to preserve subsequent columns. Follow-up to bootc-dev#2534. Assisted-by: AI Signed-off-by: Natsu <139412824+ddy314@users.noreply.github.com>
b81d1b5 to
9212b89
Compare
An empty quoted entry type currently falls through as an unknown directive and is silently ignored. Reject it as a parse failure while continuing to allow empty optional fields.
Follow-up to #2534 and the maintainer-approved review discussion: #2534 (comment).
Validation: the added case fails before the fix; all 13
bootc-sysuserstests, targeted strict Clippy, formatting, andgit diff --checkpass. An independent code review found no actionable issues.Assisted-by: AI. Implementation and tests were prepared with AI assistance. The contributor reviewed the patch and explicitly authorized DCO signoff and marking this PR ready for review.