Skip to content

fix: translate Borg prepare errors shown in the UI - #2623

Merged
m3nu merged 2 commits into
borgbase:masterfrom
kg290:codex/fix-2604-prepare-error-translations
Nov 15, 2026
Merged

m3nu merged 2 commits into
borgbase:masterfrom
kg290:codex/fix-2604-prepare-error-translations

Conversation

@kg290

@kg290 kg290 commented Nov 15, 2026

Copy link
Copy Markdown
Contributor

Description

Translate Borg prepare errors at all 15 affected UI display sites using the existing messages context. Job messages, logs, and translation catalogs stay unchanged.

Related Issue

Fixes #2604.

Motivation and Context

These errors appeared in English even when the app used another language.

How Has This Been Tested?

Ubuntu 24.04 (WSL), Python 3.12, Qt 6.12:

  • Four regression cases reproduced the bug before the fix.
  • uv run pytest tests/unit/test_archives.py tests/unit/test_repo.py tests/unit/test_lock.py tests/unit/test_diff.py tests/unit/test_extract.py: 95 passed (Qt offscreen).
  • Ruff lint and format checks, plus all applicable pre-commit hooks on changed files, passed.
  • Full test suite not run.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the contributing guide.
  • My code follows the project style.
  • I have added tests to cover my changes.
  • Documentation changes are not needed.

I provide this contribution under the repository license and affirm the Developer Certificate of Origin.

Signed-off-by: Karnajeet Gosasvi <karnajeet.gosavi23@vit.edu>
Copilot AI balanced review requested due to automatic review settings November 15, 2026 09:05

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

@m3nu
m3nu merged commit 965bad4 into borgbase:master Nov 15, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Translate Borg prepare errors shown in the UI

3 participants