Skip to content

fix: clean up Borg job events and lock statistics resets - #2625

Merged
m3nu merged 3 commits into
borgbase:masterfrom
kg290:codex/fix-2608-borg-job-events
Nov 15, 2026
Merged

m3nu merged 3 commits into
borgbase:masterfrom
kg290:codex/fix-2608-borg-job-events

Conversation

@kg290

@kg290 kg290 commented Nov 15, 2026

Copy link
Copy Markdown
Contributor

Description

Remove three unused Borg job overrides, fix the compaction status prefix, and share the prune/delete statistics reset in process_result, under the database lock.

Keep statistics invalidation on failures, including exceptions, before completion signals. Result handlers that raise are not retried.

Related Issue

Fixes #2608.

Motivation and Context

Prune/delete updated cached statistics outside the database lock, and compaction displayed misplaced brackets.

How Has This Been Tested?

Ubuntu 24.04 (WSL), Python 3.12, Qt 6.12, Borg 1.2.8:

  • Nine regression cases reproduced the bugs before the fix.
  • Related job, archive, extraction and scheduler unit tests: 154 passed.
  • Real Borg integration tests: 3 passed.
  • Final job/exception/integration recheck after moving the helper: 31 passed.
  • Ruff lint, formatting, and applicable pre-commit checks passed.
  • Full suite and macOS runtime not tested.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the contributing guide.
  • My code follows the project style.
  • I have added tests to cover my changes.
  • Documentation changes are not needed.

I provide this contribution under the repository license and affirm the Developer Certificate of Origin.

Signed-off-by: Karnajeet Gosasvi <karnajeet.gosavi23@vit.edu>
Copilot AI balanced review requested due to automatic review settings November 15, 2026 09:16

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

BorgCompactJob.prepare() needs Borg >= 1.2, but unit tests start with the 1.1.4 default.

Signed-off-by: Manu <manu@snapdragon.cc>
@m3nu
m3nu merged commit 34d6571 into borgbase:master Nov 15, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove dead BorgJob overrides and fix compact/prune/delete events

3 participants