Repository navigation
fix: clean up Borg job events and lock statistics resets - #2625
Merged
Merged
Conversation
Signed-off-by: Karnajeet Gosasvi <karnajeet.gosavi23@vit.edu>
BorgCompactJob.prepare() needs Borg >= 1.2, but unit tests start with the 1.1.4 default. Signed-off-by: Manu <manu@snapdragon.cc>
m3nu
approved these changes
Nov 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove three unused Borg job overrides, fix the compaction status prefix, and share the prune/delete statistics reset in
process_result, under the database lock.Keep statistics invalidation on failures, including exceptions, before completion signals. Result handlers that raise are not retried.
Related Issue
Fixes #2608.
Motivation and Context
Prune/delete updated cached statistics outside the database lock, and compaction displayed misplaced brackets.
How Has This Been Tested?
Ubuntu 24.04 (WSL), Python 3.12, Qt 6.12, Borg 1.2.8:
Types of changes
Checklist
I provide this contribution under the repository license and affirm the Developer Certificate of Origin.