Skip to content

fix: keep daily backup slots after midnight-crossing runs - #2626

Merged
m3nu merged 2 commits into
borgbase:masterfrom
kg290:codex/fix-2612-daily-schedule
Nov 15, 2026
Merged

m3nu merged 2 commits into
borgbase:masterfrom
kg290:codex/fix-2612-daily-schedule

Conversation

@kg290

@kg290 kg290 commented Nov 15, 2026

Copy link
Copy Markdown
Contributor

Description

Schedule the next daily backup at the first configured time after the last backup's start, rather than the day after it finished. Select the latest run by start time. Interval mode still counts from completion.

Related Issue

Fixes #2612.

Motivation and Context

A backup crossing midnight could skip the following day's slot. Delayed and catch-up runs should also leave the next daily slot available.

How Has This Been Tested?

Ubuntu 24.04 (WSL), Python 3.12, Qt 6.12, using Qt offscreen:

  • uv run pytest tests/unit/test_scheduler.py tests/unit/test_schedule.py: 125 passed.
  • Covers midnight crossings, delayed/manual runs, long backups, catch-up settings, latest-run selection, and interval timing.
  • Ruff lint, formatting, and applicable pre-commit checks passed.
  • Full suite and macOS runtime not tested.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the contributing guide.
  • My code follows the project style.
  • I have added tests to cover my changes.
  • Documentation changes are not needed.

I provide this contribution under the repository license and affirm the Developer Certificate of Origin.

Signed-off-by: Karnajeet Gosasvi <karnajeet.gosavi23@vit.edu>
Copilot AI balanced review requested due to automatic review settings November 15, 2026 09:23

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

@m3nu
m3nu merged commit fd5fdd0 into borgbase:master Nov 15, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Daily schedule skips the next day when a backup ends after midnight

3 participants