Skip to content

fix: re-arm scheduler after results and repository changes - #2628

Merged
m3nu merged 2 commits into
borgbase:masterfrom
kg290:codex/fix-2603-scheduler-rearming
Nov 15, 2026
Merged

m3nu merged 2 commits into
borgbase:masterfrom
kg290:codex/fix-2603-scheduler-rearming

Conversation

@kg290

@kg290 kg290 commented Nov 15, 2026

Copy link
Copy Markdown
Contributor

Description

Let scheduled backups re-arm only after their result is handled. Refresh timers when a repository is changed or unset, and refresh offline schedule displays without losing paused status.

Related Issue

Fixes #2603.

Motivation and Context

Prevents immediate retries after a failed scheduled backup, missing-repository crashes, and stale schedule displays.

How Has This Been Tested?

Linux under WSL, Python 3.12 and Qt 6.12:

  • uv run --no-sync pytest tests/unit/test_scheduler.py tests/unit/test_repo.py tests/unit/test_schedule.py tests/unit/test_jobs_table_model.py -q --tb=short — 196 passed with QT_QPA_PLATFORM=offscreen under dbus-run-session.
  • Pre-commit checks passed for all changed files.
  • Regression tests cover failed-run retries, manual re-arming, repository removal/reselection, and offline paused status.

The full multi-version test suite was not run.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the contributing guide.
  • My code follows the project style.
  • I have added tests to cover my changes.
  • All new and existing tests passed (targeted tests only; see above).

No documentation changes are needed.

I provide this contribution under the repository license and affirm the Developer Certificate of Origin.

Signed-off-by: Karnajeet Gosasvi <karnajeet.gosavi23@vit.edu>
Copilot AI balanced review requested due to automatic review settings November 15, 2026 12:58

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

@m3nu
m3nu merged commit 4244d27 into borgbase:master Nov 15, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stop re-arming failed scheduled runs early and drop timers on repo unset

3 participants