Skip to content

fix: restore archive buttons after failed or cancelled refresh - #2630

Merged
m3nu merged 2 commits into
borgbase:masterfrom
kg290:codex/fix-2599-archive-buttons
Nov 15, 2026
Merged

m3nu merged 2 commits into
borgbase:masterfrom
kg290:codex/fix-2599-archive-buttons

Conversation

@kg290

@kg290 kg290 commented Nov 15, 2026

Copy link
Copy Markdown
Contributor

Description

Prepare all archive refresh jobs before disabling buttons. Reset the counter on cancellation and ignore late results from cancelled refreshes. Keep Compact disabled when busy or unsupported by Borg.

Related Issue

Fixes #2599.

Motivation and Context

Prevents failed or cancelled refreshes from leaving archive actions and Start Backup disabled.

How Has This Been Tested?

Linux under WSL, Python 3.12, Qt 6.12, Borg 1.2.8; pytest run via uv run --no-sync with offscreen Qt and dbus-run-session.

  • Full unit suite: 633 passed, 13 skipped.
  • Archive integration tests excluding FUSE mounting: 8 passed across runs. Extraction initially failed because the test assumes /tmp; it passed when rerun with that directory layout.
  • Pre-commit checks passed for both changed files.

Regression tests cover preparation failure, empty selection, cancellation, late results, and Compact availability. macOS and the full Borg-version matrix were not tested locally.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the contributing guide.
  • My code follows the project style.
  • I have added tests to cover my changes.
  • All new and existing tests passed (validation scope and skips listed above).

No documentation changes are needed.

I provide this contribution under the repository license and affirm the Developer Certificate of Origin.

Signed-off-by: Karnajeet Gosasvi <karnajeet.gosavi23@vit.edu>
Copilot AI balanced review requested due to automatic review settings November 15, 2026 13:23

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

@m3nu
m3nu merged commit 9f88a33 into borgbase:master Nov 15, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix archive buttons stuck disabled after failed or cancelled refresh

3 participants