Repository navigation
fix: restore archive buttons after failed or cancelled refresh - #2630
Merged
Merged
Conversation
Signed-off-by: Karnajeet Gosasvi <karnajeet.gosavi23@vit.edu>
m3nu
approved these changes
Nov 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Prepare all archive refresh jobs before disabling buttons. Reset the counter on cancellation and ignore late results from cancelled refreshes. Keep Compact disabled when busy or unsupported by Borg.
Related Issue
Fixes #2599.
Motivation and Context
Prevents failed or cancelled refreshes from leaving archive actions and Start Backup disabled.
How Has This Been Tested?
Linux under WSL, Python 3.12, Qt 6.12, Borg 1.2.8; pytest run via
uv run --no-syncwith offscreen Qt anddbus-run-session./tmp; it passed when rerun with that directory layout.Regression tests cover preparation failure, empty selection, cancellation, late results, and Compact availability. macOS and the full Borg-version matrix were not tested locally.
Types of changes
Checklist
No documentation changes are needed.
I provide this contribution under the repository license and affirm the Developer Certificate of Origin.