Repository navigation
Capture new Claude Code hook fields (effort, duration_ms, is_interrupt) #200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Abhijeet Prasad (AbhiPrasad)
wants to merge
2
commits into
main
Choose a base branch
from
check-claude-code-hooks-9-6b6e3d65
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Claude does not consistently include
effortonUserPromptSubmit: for example,subagent-compact/events.ndjsonline 2 omits it and the correspondingStopon line 4 reportshigh. Becauseopen_turnsnapshotsself.effortonly when the turn opens, this assignment merely caches the late value for the next turn and never adds it to the turn that produced the hook. Consequently, the first turn loses known effort metadata, and after an effort change a later turn can retain the previous level until another turn opens; merge newly observed effort into the currently active turn as well.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, fixed in 8e34e04. The recorded fixtures confirm that
UserPromptSubmitnever carrieseffort; it only arrives on later hooks. Each turn now tracks the level it has recorded, and a newly observed level is merged into the active turn (record_turn_effort). The real-fixture test now asserts that every turn getsxhigh.