Repository navigation
ref: route all SDK diagnostics through debugLogger - #2631
Open
Abhijeet Prasad (AbhiPrasad) wants to merge 2 commits into
Open
Abhijeet Prasad (AbhiPrasad) wants to merge 2 commits into
Abhijeet Prasad (AbhiPrasad) wants to merge 2 commits into
Conversation
Notice warnings and errors print at warn when no debug log level is configured, respect an explicit level, and are silenced by debugLogLevel: false. Use it for diagnostics that were always shown before routing through debugLogger, only mark the span customizer failure as logged once it is emitted, and drop duplicate Braintrust prefixes from logger messages. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Abhijeet Prasad (AbhiPrasad)
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was looking at adding console.log instrumentation and figured we need to do this first. But open to other ideas.
Routes the SDK's remaining
console.*diagnostics throughdebugLogger. AddsdebugLogger.noticefor user-facing messages that should stay visible by default.notice.*configureInstrumentation, span customizer failure, dev server errors,publish()warnings, scorer/vitest warnings, auto-instrumentation transform failureswarn/error/debugBehavior changes
BRAINTRUST_DEBUG_LOG_LEVEL/debugLogLevelDEBUG='@braintrust*'showed auto-instrumentation statusBRAINTRUST_DEBUG_LOG_LEVEL=debug[braintrust] [Braintrust] ...🤖 Generated with Claude Code