Repository navigation
fix: render uploaded file prompts without inline data - #959
Draft
Kayvan Zahiri (Kayvan-Zahiri) wants to merge 1 commit into
Draft
Kayvan Zahiri (Kayvan-Zahiri) wants to merge 1 commit into
Kayvan Zahiri (Kayvan-Zahiri) wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prompt.build()raisesKeyError: 'file_data'for a chat prompt containing an uploaded PDF reference such as{"type": "file", "file": {"file_id": "{{report_file_id}}"}}. Uploaded files do not require inlinefile_data(file-input guide).Render
file_dataonly when present, matching the existing treatment offile_idandfilename. Add publicPrompt.build()regressions for uploaded and inline files in strict and non-strict mode, checking the complete message payload and preservation of the source template.Validation:
KeyError: 'file_data'; the two inline-file controls pass.This exercises local SDK prompt rendering; it does not upload a file or make a model request. Tools and dependencies were installed only in an isolated virtual environment.
miseis unavailable locally, so the pinned pre-commit hooks were run directly.AI assistance: Codex identified, reproduced, implemented, and tested this local SDK fix. Submitted as a draft for human review.