Skip to content

bind requestAnimationFrame to window for IE11 - #1111

Closed
jorgejar wants to merge 1 commit into
bvaughn:masterfrom
jorgejar:bind-animation-frame-for-ie11
Closed

jorgejar wants to merge 1 commit into
bvaughn:masterfrom
jorgejar:bind-animation-frame-for-ie11

Conversation

@jorgejar

@jorgejar jorgejar commented May 17, 2018 •

Copy link
Copy Markdown
  • currently InfiniteLoader does not trigger LoadMoreRows in IE11 because it throws an error when requestAnimationFrame is not called with the window context.

  • this PR simply binds the window to requestAnimationFrame so that when it is called, it works correctly

@jorgejar
jorgejar force-pushed the bind-animation-frame-for-ie11 branch 5 times, most recently from 56ecec2 to 8e441ee Compare May 17, 2018 18:54
Signed-off-by: jorgejar <jorge.jaramillo@docker.com>
@jorgejar
jorgejar force-pushed the bind-animation-frame-for-ie11 branch from 8e441ee to 63fab23 Compare May 17, 2018 18:55
@jorgejar

Copy link
Copy Markdown
Author

fixed formatting and squashed commits.

I just found this problem only arises with dev mode with webpack, probably how its bundled with eval, production builds work fine.
Ill keep the PR up in case it there is interest in fixing the dev mode experience.

@wuweiweiwu

Copy link
Copy Markdown
Contributor

hm. interesting.

@jorgejar do you mind creating an issue? so we'll make a note of it and prioritize accordingly. Thanks :)

@wuweiweiwu

Copy link
Copy Markdown
Contributor

Also, can you try running yarn start to start the development server for the demo website and see if the error persists? It currently works for Chrome on MacOS

@jorgejar

jorgejar commented May 23, 2018 •

Copy link
Copy Markdown
Author

Also, can you try running yarn start to start the development server for the demo website and see if the error persists? It currently works for Chrome on MacOS

this only happened on development bundles for IE11, the result from yarn start will not render in IE11, but it happened in the project I was building (dev mode only, prod ok).
I checked the issues, it looks like this would solve #986. This PR has the same solution as #1013, so Ill let the discussion happen on those threads.

@jorgejar jorgejar closed this May 23, 2018
@bvaughn

bvaughn commented Oct 18, 2026

Copy link
Copy Markdown
Owner

Thank you for this PR, and I'm sorry it took so long to get back to you!

The upcoming react-virtualized 10.0 release requires React 18 or newer and no longer supports Internet Explorer 11, so this IE11-specific change no longer applies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants