Skip to content

Rename requestAnimationTimeout to avoid conflicts - #1134

Closed
uqmessias wants to merge 1 commit into
bvaughn:masterfrom
uqmessias:master
Closed

uqmessias wants to merge 1 commit into
bvaughn:masterfrom
uqmessias:master

Conversation

@uqmessias

Copy link
Copy Markdown

For some weird reason, I was facing some issues when trying to use MultiGrid or ScrollSync.

After several hours of investigation, I realized that the issue was regarding to one utils file for wrapping the requestAnimationTimeout, more specifically to the file name.

I also left a comment on this PR (#1013) explaining my issue.

These are some additional info about the issue:

	_debounceScrollEnded
http://localhost:9090/bundle.js:20517:45
handleScrollEvent
http://localhost:9090/bundle.js:19878:7
Grid/_this._onScroll
http://localhost:9090/bundle.js:19756:9
callCallback
http://localhost:9090/bundle.js:37659:9
invokeGuardedCallbackDev
http://localhost:9090/bundle.js:37697:7
invokeGuardedCallback
http://localhost:9090/bundle.js:37746:5
invokeGuardedCallbackAndCatchFirstError
http://localhost:9090/bundle.js:37760:5
executeDispatch
http://localhost:9090/bundle.js:38020:3
executeDispatchesInOrder
http://localhost:9090/bundle.js:38039:7
executeDispatchesAndRelease
http://localhost:9090/bundle.js:38140:5
executeDispatchesAndReleaseTopLevel
http://localhost:9090/bundle.js:38151:10
forEachAccumulated
http://localhost:9090/bundle.js:38121:5
runEventsInBatch
http://localhost:9090/bundle.js:38282:5
runExtractedEventsInBatch
http://localhost:9090/bundle.js:38291:3
handleTopLevel
http://localhost:9090/bundle.js:42031:5
batchedUpdates$1
http://localhost:9090/bundle.js:54096:12
batchedUpdates
http://localhost:9090/bundle.js:39690:12
dispatchEvent
http://localhost:9090/bundle.js:42110:5
dispatchEvent self-hosted:1020:17 

image

I'd be glad to create any additional tests, but unfortunately, I don't know what to test in this case.

@TrySound

TrySound commented Jun 7, 2018

Copy link
Copy Markdown
Contributor

Could you provide a repo with reproducing this issue? It works for my project. Perhaps there is something wrong with your configuration?

@bvaughn

bvaughn commented Oct 18, 2026

Copy link
Copy Markdown
Owner

Thank you for this PR, and I'm sorry it took so long to get back to you!

The upcoming react-virtualized 10.0 release ships as a single bundled module (dist/react-virtualized.js, plus a CommonJS build) instead of one file per source module, so there is no longer a requestAnimationTimeout.js file for your bundler to resolve, and this rename no longer applies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants