Skip to content

Set the isScrolling prop in cellRenderer for the other child grids - #1201

Closed
mauricedb wants to merge 1 commit into
bvaughn:masterfrom
mauricedb:Issue-1173-MultiGrid-isScrolling
Closed

mauricedb wants to merge 1 commit into
bvaughn:masterfrom
mauricedb:Issue-1173-MultiGrid-isScrolling

Conversation

@mauricedb

@mauricedb mauricedb commented Aug 27, 2018 •

Copy link
Copy Markdown

Fixes: #1173

Before submitting a pull request, please complete the following checklist:

  • The existing test suites (npm test) all pass
  • For any new features or bug fixes, both positive and negative test cases have been added
  • For any new features, documentation has been added
  • For any documentation changes, the text has been proofread and is clear to both experienced users and beginners.
  • Format your code with prettier (npm run prettier).
  • Run the Flow typechecks (npm run typecheck).

Here is a short checklist of additional things to keep in mind before submitting:

  • Please make sure your pull request description makes it very clear what you're trying to accomplish. If it's a bug fix, please also provide a failing test case (if possible). In either case, please add additional unit test coverage for your changes. :)
  • Be sure you have notifications setup so that you'll see my code review responses. (I may ask you to make some adjustments before merging.)

Comment thread source/MultiGrid/MultiGrid.js
@minicuper

Copy link
Copy Markdown

What are we waiting for? The PR looks fine, isn't it?

@minicuper

Copy link
Copy Markdown

Just took a look at the PR, it doesn't turn off isScrolling for leftBottom and rightTop tables.

@SpencerCarstens

Copy link
Copy Markdown

Yea, I just tested and can confirm that isScrolling does not toggle back from true once set.

@mauricedb mauricedb closed this Jan 27, 2019
@bvaughn

bvaughn commented Oct 18, 2026

Copy link
Copy Markdown
Owner

Sorry for the very long delay in getting back to you about this!

I've just finished a large update for version 10 of react-virtualized (#1900): the library has been rewritten in TypeScript, every component is now a function component (React 18+ is required), and the source moved from source/ to lib/. Because of that, this PR can't be merged as-is. In version 10, MultiGrid's other quadrants still don't get isScrolling: true while the main grid is being scrolled.

If you're still interested in this change, I'd welcome a new PR with it rebased onto the version-10 branch (or onto master once version 10 has been merged).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Using the MultiGrid isScrolling is only true on the grid that scrolls

5 participants