Skip to content

Recompute range when total size and consequentely safe offset is changed - #1204

Closed
abramobagnara wants to merge 2 commits into
bvaughn:masterfrom
abramobagnara:master
Closed

abramobagnara wants to merge 2 commits into
bvaughn:masterfrom
abramobagnara:master

Conversation

@abramobagnara

@abramobagnara abramobagnara commented Aug 30, 2018 •

Copy link
Copy Markdown

This fix is needed to avoid to show the wrong range in presence of a dynamic height list with an huge count of rows (i.e. a total height in pixel greater than browser limit).

  • The existing test suites (npm test) all pass

yarn test succeeds without any failure

  • For any new features or bug fixes, both positive and negative test cases have been added

  • Format your code with prettier (npm run prettier).

yarn prettier is ok

  • Run the Flow typechecks (npm run typecheck).

@github-actions github-actions Bot added the Stale label Oct 3, 2024
@github-actions github-actions Bot closed this Oct 3, 2024
@bvaughn

bvaughn commented Oct 18, 2026

Copy link
Copy Markdown
Owner

Sorry for the very long delay in getting back to you about this!

I've just finished a large update for version 10 of react-virtualized (#1900): the library has been rewritten in TypeScript, every component is now a function component (React 18+ is required), and the source moved from source/ to lib/. Because of that, this PR can't be merged as-is. Version 10 still converts the scaled offset only once, so the visible range can still be off for very large lists with variable row sizes (though offsets are now only scaled above about 16.7M px).

If you're still interested in this change, I'd welcome a new PR with it rebased onto the version-10 branch (or onto master once version 10 has been merged).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants