Skip to content

When scrollToAlignment is 'auto' and list item height is greater than list height, list item will be scrolled into view with 'start' alignment instead of 'auto'. - #1264

Closed
OmkarRajam wants to merge 1 commit into
bvaughn:masterfrom
OmkarRajam:seeTitleWhenForceScrolled
Closed

OmkarRajam wants to merge 1 commit into
bvaughn:masterfrom
OmkarRajam:seeTitleWhenForceScrolled

Conversation

@OmkarRajam

@OmkarRajam OmkarRajam commented Nov 7, 2018 •

Copy link
Copy Markdown

Fixes #1263
See this issue that was added by me. This PR solves this issue.

Before submitting a pull request, please complete the following checklist:

  • The existing test suites (npm test) all pass
  • For any new features or bug fixes, both positive and negative test cases have been added
  • For any new features, documentation has been added
  • For any documentation changes, the text has been proofread and is clear to both experienced users and beginners.
  • Format your code with prettier (npm run prettier).
  • Run the Flow typechecks (npm run typecheck).

…ist height, list item will scroll with start alignment instead of auto.
@OmkarRajam OmkarRajam changed the title When scrollToAlignment is auto and list item height is greater than list height, list item will scroll with start alignment instead of auto. When scrollToAlignment is 'auto' and list item height is greater than list height, list item will scroll with 'start' alignment instead of 'auto'. Nov 7, 2018
@OmkarRajam OmkarRajam changed the title When scrollToAlignment is 'auto' and list item height is greater than list height, list item will scroll with 'start' alignment instead of 'auto'. When scrollToAlignment is 'auto' and list item height is greater than list height, list item will be scrolled into view with 'start' alignment instead of 'auto'. Nov 7, 2018
@github-actions github-actions Bot added the Stale label Sep 29, 2024
@github-actions github-actions Bot closed this Sep 29, 2024
@bvaughn

bvaughn commented Oct 18, 2026

Copy link
Copy Markdown
Owner

Sorry for the very long delay in getting back to you about this!

This is fixed in the upcoming version 10 of react-virtualized (#1900), using the approach from this PR: with align: "auto" (the default), scrollToRow and scrollToCell (and ArrowKeyStepper) now align a row or cell that is larger than the viewport to its start, so its start is visible (#1263). Thank you for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Large list items are center aligned instead of top aligned during keyboard navigation

2 participants