Skip to content

issue/696 : Multigrid falls out of sync with 50k+ items when scrollbars are on. - #1300

Closed
MIKL99999 wants to merge 1 commit into
bvaughn:masterfrom
MIKL99999:issue/696
Closed

MIKL99999 wants to merge 1 commit into
bvaughn:masterfrom
MIKL99999:issue/696

Conversation

@MIKL99999

Copy link
Copy Markdown
  • Remove additionalRowCount.
  • When bottomRightGrid has scrollbar add height style to bottomLeftGrid
    to compensate the difference of grids containers height,
    which appears due scrollbar size.
  • Fix MultiGrid test.

Thanks for contributing to react-virtualized!

Before submitting a pull request, please complete the following checklist:

  • [+] The existing test suites (npm test) all pass
  • [+] For any new features or bug fixes, both positive and negative test cases have been added
  • [+] For any new features, documentation has been added
  • [+] For any documentation changes, the text has been proofread and is clear to both experienced users and beginners.
  • [+] Format your code with prettier (npm run prettier).
  • [+] Run the Flow typechecks (npm run typecheck).

Here is a short checklist of additional things to keep in mind before submitting:

  • Please make sure your pull request description makes it very clear what you're trying to accomplish. If it's a bug fix, please also provide a failing test case (if possible). In either case, please add additional unit test coverage for your changes. :)
  • Be sure you have notifications setup so that you'll see my code review responses. (I may ask you to make some adjustments before merging.)

- Remove additionalRowCount.
- When bottomRightGrid has scrollbar add height style to bottomLeftGrid
   to compensate the difference of grids containers height,
   which appears due scrollbar size.
- Fix MultiGrid test.
@jeremyk

jeremyk commented Feb 8, 2019

Copy link
Copy Markdown

Any updates on this? We are seeing this issue as well.

@MIKL99999

Copy link
Copy Markdown
Author

@jeremyk
No answer from maintainers, yet.
As a hotfix, you can inherit from MultiGrid class and override changed methods.

@jeremyk

jeremyk commented Feb 11, 2019

Copy link
Copy Markdown

Thanks, I will try that.

@jeremyk

jeremyk commented Feb 11, 2019

Copy link
Copy Markdown

@MIKL99999 - I tried your but it caused other bugs in interactions with the scroll bars.

@MIKL99999

Copy link
Copy Markdown
Author

@jeremyk Can you describe those bugs?

@github-actions github-actions Bot added the Stale label Sep 26, 2024
@github-actions github-actions Bot closed this Sep 26, 2024
@bvaughn

bvaughn commented Oct 18, 2026

Copy link
Copy Markdown
Owner

Sorry for the very long delay in getting back to you about this!

I've just finished a large update for version 10 of react-virtualized (#1900): the library has been rewritten in TypeScript, every component is now a function component (React 18+ is required), and the source moved from source/ to lib/. Because of that, this PR can't be merged as-is. Version 10's MultiGrid still uses the spacer row approach, though offsets are now only scaled above about 16.7M px, so the 50k-row repro from #696 may behave differently now.

If you're still interested in this change, I'd welcome a new PR with it rebased onto the version-10 branch (or onto master once version 10 has been merged).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants