Skip to content

Add parentRenderer - It helps with complex animations - #1340

Closed
jucastilhoduarte wants to merge 2 commits into
bvaughn:masterfrom
jucastilhoduarte:parent-renderer
Closed

jucastilhoduarte wants to merge 2 commits into
bvaughn:masterfrom
jucastilhoduarte:parent-renderer

Conversation

@jucastilhoduarte

@jucastilhoduarte jucastilhoduarte commented Feb 26, 2019 •

Copy link
Copy Markdown

Sometimes we need a custom parent to manage complex animations, using libraries like https://github.com/joshwcomeau/react-flip-move.

Libraries like FlipMove do not create a new DOM element, so we can use it with Masonry, wrapping our cells without side effects.

parentRenderer is responsible for rendering a custom parent component. It's required when dealing with animations libraries like react-flip-toolkit.
@jucastilhoduarte jucastilhoduarte changed the title Add parentRenderer Add parentRenderer - It helps with complex animations Mar 15, 2019
@jucastilhoduarte
jucastilhoduarte deleted the parent-renderer branch April 5, 2019 13:12
@bvaughn

bvaughn commented Oct 18, 2026

Copy link
Copy Markdown
Owner

Sorry for the very long delay in getting back to you about this!

I've just finished a large update for version 10 of react-virtualized (#1900): the library has been rewritten in TypeScript, every component is now a function component (React 18+ is required), and the source moved from source/ to lib/. Because of that, this PR can't be merged as-is. Version 10's Masonry still has no way to wrap the rendered cells.

If you're still interested in this change, I'd welcome a new PR with it rebased onto the version-10 branch (or onto master once version 10 has been merged).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants