[OnkelTem]

Thanks for contributing to react-virtualized!

Before submitting a pull request, please complete the following checklist:

• The existing test suites (npm test) all pass
• For any new features or bug fixes, both positive and negative test cases have been added
• For any new features, documentation has been added
• For any documentation changes, the text has been proofread and is clear to both experienced users and beginners.
• Format your code with prettier (yarn run prettier).
• Run the Flow typechecks (yarn run typecheck).

See: #1316

This patch changes the following:

• removes required from Column's width and assigns auto to flex-basis by default;
• allows to use any string and number value for Column's width.

[codecov-io]

Codecov Report

Merging #1476 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1476      +/-   ##
==========================================
+ Coverage    94.7%   94.71%   +<.01%     
==========================================
  Files          47       47              
  Lines        1795     1796       +1     
==========================================
+ Hits         1700     1701       +1     
  Misses         95       95

Impacted Files	Coverage Δ
source/Table/Column.js	100% <ø> (ø)	⬆️
source/Table/Table.js	88.69% <100%> (+0.09%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad85acc...f2d49d0. Read the comment docs.

[Clearmist]

This is a very good change, but it's been six months. Consider merging then updating the documentation later.

[jackHedaya]

Bump

[chaim0m]

double bump

[kasleet]

+1

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.71%. Comparing base (ad85acc) to head (f2d49d0).
Report is 47 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1476   +/-   ##
=======================================
  Coverage   94.70%   94.71%           
=======================================
  Files          47       47           
  Lines        1795     1796    +1     
=======================================
+ Hits         1700     1701    +1     
  Misses         95       95           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[bvaughn]

Sorry for the very long delay in getting back to you about this!

I've just finished a large update for version 10 of react-virtualized (#1900): the library has been rewritten in TypeScript, every component is now a function component (React 18+ is required), and the source moved from source/ to lib/. Because of that, this PR can't be merged as-is. Version 10's Column still requires a numeric width.

If you're still interested in this change, I'd welcome a new PR with it rebased onto the version-10 branch (or onto master once version 10 has been merged).