Skip to content

Add RTL support to Grid - #1505

Closed
albertfdp wants to merge 7 commits into
bvaughn:masterfrom
albertfdp:feat/grid-rtl
Closed

albertfdp wants to merge 7 commits into
bvaughn:masterfrom
albertfdp:feat/grid-rtl

Conversation

@albertfdp

@albertfdp albertfdp commented Feb 28, 2020 •

Copy link
Copy Markdown

This PR adds support to dynamically update the direction (rtl|ltr) of the Grid component. The implementation is partially based on the equivalent of https://github.com/bvaughn/react-window/blob/master/src/createGridComponent.js

Direction of ltr has no effect on the actual implementation and should produce no changes. Setting rtl however will make the Grid be scrollable from the right, and column 0 will be the first starting from the right.

Running example at https://albertfdp.github.io/react-virtualized/#/components/Grid

  • The existing test suites (npm test) all pass
  • For any new features or bug fixes, both positive and negative test cases have been added
  • For any new features, documentation has been added
  • For any documentation changes, the text has been proofread and is clear to both experienced users and beginners.
  • Format your code with prettier (yarn run prettier).
  • Run the Flow typechecks (yarn run typecheck).

@albertfdp albertfdp changed the title Feat/grid rtl Add RTL support to Grid Feb 28, 2020
@EmanuelBenHamo

Copy link
Copy Markdown

Thanks @albertfdp !
We forked your repo, merged the grid-rtl branch to master and published it to npm in order to support rtl in our website.
Your rtl support is on our production code and works good :)
Until this pull request will be merged, you can use the package that we published to npm:
https://www.npmjs.com/package/react-virtualized-carwiz

@github-actions github-actions Bot added the Stale label Sep 13, 2024
@github-actions github-actions Bot closed this Sep 13, 2024
@bvaughn

bvaughn commented Oct 18, 2026

Copy link
Copy Markdown
Owner

Sorry for the very long delay in getting back to you about this!

I've just finished a large update for version 10 of react-virtualized (#1900): the library has been rewritten in TypeScript, every component is now a function component (React 18+ is required), and the source moved from source/ to lib/. Because of that, this PR can't be merged as-is. Version 10 still doesn't support RTL layouts.

If you're still interested in this change, I'd welcome a new PR with it rebased onto the version-10 branch (or onto master once version 10 has been merged).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants