You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Direction of ltr has no effect on the actual implementation and should produce no changes. Setting rtl however will make the Grid be scrollable from the right, and column 0 will be the first starting from the right.
Thanks @albertfdp !
We forked your repo, merged the grid-rtl branch to master and published it to npm in order to support rtl in our website.
Your rtl support is on our production code and works good :)
Until this pull request will be merged, you can use the package that we published to npm: https://www.npmjs.com/package/react-virtualized-carwiz
Sorry for the very long delay in getting back to you about this!
I've just finished a large update for version 10 of react-virtualized (#1900): the library has been rewritten in TypeScript, every component is now a function component (React 18+ is required), and the source moved from source/ to lib/. Because of that, this PR can't be merged as-is. Version 10 still doesn't support RTL layouts.
If you're still interested in this change, I'd welcome a new PR with it rebased onto the version-10 branch (or onto master once version 10 has been merged).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support to dynamically update the direction (
rtl|ltr) of the Grid component. The implementation is partially based on the equivalent of https://github.com/bvaughn/react-window/blob/master/src/createGridComponent.jsDirection of
ltrhas no effect on the actual implementation and should produce no changes. Settingrtlhowever will make the Grid be scrollable from the right, and column 0 will be the first starting from the right.Running example at https://albertfdp.github.io/react-virtualized/#/components/Grid
npm test) all passyarn run prettier).yarn run typecheck).