Skip to content

Add event to onScrollToChange function args - #1549

Closed
Atralbus wants to merge 1 commit into
bvaughn:masterfrom
Atralbus:arrow-key-stepper-event
Closed

Atralbus wants to merge 1 commit into
bvaughn:masterfrom
Atralbus:arrow-key-stepper-event

Conversation

@Atralbus

@Atralbus Atralbus commented Jun 23, 2020 •

Copy link
Copy Markdown

Hi,
I thought it might increase the controllability if we pass the event as an argument to onScrollToChange function. For example; if we want to use event.shiftKey | event.ctrlKey for a different behavior.

  • The existing test suites (npm test) all pass
  • For any new features or bug fixes, both positive and negative test cases have been added
  • For any new features, documentation has been added
  • For any documentation changes, the text has been proofread and is clear to both experienced users and beginners.
  • Format your code with prettier (yarn run prettier).
  • Run the Flow typechecks (yarn run typecheck).

@github-actions github-actions Bot added the Stale label Sep 9, 2024
@github-actions github-actions Bot closed this Sep 9, 2024
@bvaughn

bvaughn commented Oct 18, 2026

Copy link
Copy Markdown
Owner

Sorry for the very long delay in getting back to you about this!

I've just finished a large update for version 10 of react-virtualized (#1900): the library has been rewritten in TypeScript, every component is now a function component (React 18+ is required), and the source moved from source/ to lib/. Because of that, this PR can't be merged as-is. Version 10's ArrowKeyStepper still passes only the indices to onScrollToChange.

If you're still interested in this change, I'd welcome a new PR with it rebased onto the version-10 branch (or onto master once version 10 has been merged).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants