Skip to content

Adding role list to List component - #1673

Closed
nattri wants to merge 1 commit into
bvaughn:masterfrom
nattri:bugfix/issue-1657
Closed

nattri wants to merge 1 commit into
bvaughn:masterfrom
nattri:bugfix/issue-1657

Conversation

@nattri

@nattri nattri commented Jul 19, 2021

Copy link
Copy Markdown

Added role=list for the List component as currently it has role="grid" which is creating accessibility issue in mac voiceover.
Here is the issue ticket - #1657

@jcurtis

jcurtis commented Apr 25, 2022

Copy link
Copy Markdown

Are there any unit tests that could be added/updated for this?

@github-actions github-actions Bot added the Stale label Aug 29, 2024
@github-actions github-actions Bot closed this Aug 29, 2024
@ericbf

ericbf commented Aug 31, 2024

Copy link
Copy Markdown

This is still an issue

@bvaughn

bvaughn commented Oct 18, 2026

Copy link
Copy Markdown
Owner

Sorry for the very long delay in getting back to you about this!

This is fixed in the upcoming version 10 of react-virtualized (#1900), following the idea in this PR: List now defaults to role="list", rows that don't specify a role get role="listitem", and the placeholder aria-label="grid" is no longer set by default (#1657). role="grid" still gives the old roles for anyone who relies on them. Thank you for pushing for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants