Skip to content

Add Feature: Footer row support in table - #1710

Closed
venkateshsundaram wants to merge 10 commits into
bvaughn:masterfrom
venkateshsundaram:footer-support
Closed

venkateshsundaram wants to merge 10 commits into
bvaughn:masterfrom
venkateshsundaram:footer-support

Conversation

@venkateshsundaram

@venkateshsundaram venkateshsundaram commented Nov 28, 2021 •

Copy link
Copy Markdown

Thanks for contributing to react-virtualized!

Description

Supporting footer row in table for react-virtualized.

Before submitting a pull request, please complete the following checklist:

  • The existing test suites (npm test) all pass
  • For any new features or bug fixes, both positive and negative test cases have been added
  • For any new features, documentation has been added
  • For any documentation changes, the text has been proofread and is clear to both experienced users and beginners.
  • Format your code with prettier (yarn run prettier).
  • Run the Flow typechecks (yarn run typecheck).

Here is a short checklist of additional things to keep in mind before submitting:

  • Please make sure your pull request description makes it very clear what you're trying to accomplish. If it's a bug fix, please also provide a failing test case (if possible). In either case, please add additional unit test coverage for your changes. :)
  • Be sure you have notifications setup so that you'll see my code review responses. (I may ask you to make some adjustments before merging.)

Screenshots

Original Update
**
react-virtualized(before)** ** after 2 react-virtualized**

@venkateshsundaram

venkateshsundaram commented Nov 29, 2021 •

Copy link
Copy Markdown
Author

Footer row will work accordingly based on more rows(data with scroll) and less rows (data without scroll)

Real time Usage:

Footer.Row.Virtualized.mov

@venkateshsundaram venkateshsundaram changed the title Add Feature: Footer support Add Feature: Footer row support in table Nov 30, 2021
@venkateshsundaram

Copy link
Copy Markdown
Author

Hi @wuweiweiwu Can you pls help me to merge?

@github-actions github-actions Bot added the Stale label Aug 26, 2024
@github-actions github-actions Bot closed this Aug 26, 2024
@bvaughn

bvaughn commented Oct 18, 2026

Copy link
Copy Markdown
Owner

Sorry for the very long delay in getting back to you about this!

I've just finished a large update for version 10 of react-virtualized (#1900): the library has been rewritten in TypeScript, every component is now a function component (React 18+ is required), and the source moved from source/ to lib/. Because of that, this PR can't be merged as-is. Version 10's Table still has no footer row support.

If you're still interested in this change, I'd welcome a new PR with it rebased onto the version-10 branch (or onto master once version 10 has been merged).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants