Skip to content

Fix onScrollbarPresenceChange not invoking at correct timing - #1712

Closed
NoyChan wants to merge 1 commit into
bvaughn:masterfrom
NoyChan:scrollbar-change
Closed

NoyChan wants to merge 1 commit into
bvaughn:masterfrom
NoyChan:scrollbar-change

Conversation

@NoyChan

@NoyChan NoyChan commented Dec 14, 2021

Copy link
Copy Markdown

Hi
I noticed that the calculation of verticalScrollBarSize does not consider the current horizontalScrollBarSize, and vice versa, which lead to incorrect invoke timing of onScrollbarPresenceChange, as shown below
before
after adding this._horizontalScrollBarSize and this._verticalScrollBarSize, it work normal
after

@github-actions github-actions Bot added the Stale label Aug 25, 2024
@github-actions github-actions Bot closed this Aug 25, 2024
@bvaughn

bvaughn commented Oct 18, 2026

Copy link
Copy Markdown
Owner

Sorry for the very long delay in getting back to you about this!

I've just finished a large update for version 10 of react-virtualized (#1900): the library has been rewritten in TypeScript, every component is now a function component (React 18+ is required), and the source moved from source/ to lib/. Because of that, this PR can't be merged as-is. Version 10's Grid still checks each scrollbar's presence independently, so onScrollbarPresenceChange can still fire at the wrong time.

If you're still interested in this change, I'd welcome a new PR with it rebased onto the version-10 branch (or onto master once version 10 has been merged).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants