Repository navigation
Conversation
bvaughn
left a comment
There was a problem hiding this comment.
At a glance- this looks reasonable. But can we get at least one unit test that verifies this behavior? It would be nice if there was a test that rendered the <table> HTML structure you want so that we could ensure that (a) it works and (b) it doesn't get broken with a future update.
|
Closing due to lack of response to PR feedback. If you decide to pick this back up I'll be happy to look at it again. 😄 Cheers! |
|
Sorry for the very long delay in getting back to you about this! I've just finished a large update for version 10 of react-virtualized (#1900): the library has been rewritten in TypeScript, every component is now a function component (React 18+ is required), and the source moved from If you're still interested in this change, I'd welcome a new PR with it rebased onto the |
This PR refers to #817 and just improves component
Tablefor now due to good input in #819.Work includes:
columnHeaderRenderercolumnHeaderRenderer_createHeader->_createColumnHeaderNotes:
For further details pls. see issue.