fix(agent): propagate file upload read errors - #754
Open
felix-windsor wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
io.ReadFullduring file uploadsProblem
The upload loop stores the result of
io.ReadFullinrerr, but checks the unrelated outererrvariable. A disk or network-filesystem read error is therefore ignored, and the loop may send an incomplete chunk as if the read succeeded.The helper introduced here classifies successful/full reads, normal completion (
io.EOFandio.ErrUnexpectedEOF), and actual read failures explicitly. The caller returns beforeclient.Sendwhen a real read failure occurs.Validation
go test ./transport/file_ext.go ./transport/file_ext_test.goGOOS=linux GOARCH=amd64 go test -c -o /tmp/elkeid-transport.test ./transportGOOS=linux GOARCH=amd64 go vet ./transportgo vet ./transport/file_ext.go ./transport/file_ext_test.goThe package-wide test executable is cross-compiled because the agent only provides
plugin.LoadandPlugin.Shutdownimplementations for Linux.Fixes #748