Skip to content

Three repositories have no unit tests (notification-outbox, notification-delivery-log, nip05-verification) #905

Open

Description

@chappie-daemon

Gap

Three repositories have no unit tests — no spec file imports them:

  • src/repositories/notification-outbox-repository.ts (162 lines)
  • src/repositories/nip05-verification-repository.ts (140 lines)
  • src/repositories/notification-delivery-log-repository.ts (96 lines)

Note the trap: test/unit/services/notification-outbox-service.spec.ts exists, but it stubs the repository (claimBatch, markDelivered, markFailed are all sinon stubs) — so the 162 lines of actual SQL in the repository are untested. The user, invoice, event, and invite-code repositories all have specs; these three don't.

How measured

Import graph over the suite: 175 spec files vs 325 src/**/*.ts files — zero spec files reference these three modules (the service spec references the repository only as a stubbed interface).

What's worth covering

  • Outbox claimBatch semantics: batch claiming without double-delivery across workers
  • markDelivered / markFailed state transitions and failure-count accounting
  • nip05-verification-repository.listForAdmin filters (domain, verified, stale, minFailures, pagination) — new in feat(admin): add operations console for mirrors, workers, and NIP-05  #895 and already serving the admin API untested
  • Delivery-log writes: what gets recorded on success vs failure

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

No labels
No labels

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions