Repository navigation
feat(payments): add subscription lifecycle, renewal invoices and plan-based write access - #909
Open
Priyanshubhartistm wants to merge 4 commits into
Open
Priyanshubhartistm wants to merge 4 commits into
Priyanshubhartistm wants to merge 4 commits into
Conversation
🦋 Changeset detectedLatest commit: 4667dc0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Collaborator
Coverage Report for CI Build 39453853954Coverage increased (+0.4%) to 74.21%Details
Uncovered Changes
Coverage RegressionsNo coverage regressions found. Coverage Stats💛 - Coveralls |
[Medium impact] The PR changes recurring payment and write-access behavior for relays using subscription plans. The PR still needs a paging fix so permanently failed rows cannot block later subscribers. Findings
|
…-based write access Signed-off-by: Priyanshubhartistm <bhartipriyanshustm@gmail.com>
…anned scope Signed-off-by: Priyanshubhartistm <bhartipriyanshustm@gmail.com>
Signed-off-by: Priyanshubhartistm <bhartipriyanshustm@gmail.com>
Signed-off-by: Priyanshubhartistm <bhartipriyanshustm@gmail.com>
Priyanshubhartistm
force-pushed
the
feat/subscription-lifecycle
branch
from
October 20, 2026 16:02
8d0974a to
4667dc0
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Builds on the subscription data model (#849). Nothing changes unless
payments.enabledis true andpayments.subscriptionPlansis non-empty.POST /invoicestakes aplanId(instead of a fee schedule) when plans are configured. The invoice is created for the plan price and stores the plan.PaymentsService.confirmInvoicestarts or extends the subscription in the same transaction as the invoice confirmation, and admits the user. The plan comes from the stored invoice, so the five confirmation paths (maintenance poll and the Zebedee/LNbits/OpenNode/Nodeless callbacks) need no change. A payment below the plan price does not start or extend a period.SubscriptionService.processLifecycle, run from the maintenance worker each minute: moves subscriptions whose period ended into grace (counted from the period end) or straight to expired (plan has no grace), expires subscriptions whose grace is over, and about three days before a period ends creates a renewal invoice and marks itrenewal_pending. Each pass is bounded and a stuck row cannot loop it.isUserAdmittedchecks the subscription behind the existing admission cache (no extra read per event). Access is judged from the dates, not only the stored status, so a lagging sweep neither locks anyone out nor keeps them in, and the admitted cache entry never outlives the end of access. Admitted users with no subscription row (admitted after the migration, or by invite code / NIP-43) keep access.CONFIGURATION.mddescribes the behaviour; the.knip.jsonignore for the new repository is removed now that it is used.Related Issue
Closes #908
Motivation and Context
With the data model in place nothing created or ended a subscription: write access still depended only on the permanent
is_admittedflag. This adds the billing lifecycle (subscribe, renew, grace, expire) on the existing processors.