Repository navigation
Fix generated docs job for protobuf-lf version compatibility - #1986
Merged
Merged
Conversation
Canton 3.7 changed VersioningCompanion.protoVersionFor(ProtocolVersion) to return Either[String, ProtoVersion]. Match on the runtime result so the script compiles against both 3.6.x and 3.7.x release binaries. Signed-off-by: danielporterda <daniel.porter@digitalasset.com>
Newer Canton releases stop listing protocol versions they no longer support, so regenerating from the latest release dropped rows such as 34 and 35. Merge the rows already on the page with the release's rows, letting the release win where they overlap. Signed-off-by: danielporterda <daniel.porter@digitalasset.com>
danielporterda
changed the title
Resolve the default release by highest version rather than GitHub's most recently published Latest, so older release-line patches never feed the table. With the source always the newest line, drop the 3.6 compatibility branch and exclude Canton's dev and alpha placeholder protocol versions, removing the existing 2147483646 row. Signed-off-by: danielporterda <daniel.porter@digitalasset.com>
Contributor
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Automations to automatically generate PRs for you. |
danielporterda
changed the title
danielporterda
marked this pull request as ready for review
October 30, 2026 13:59
danielporterda
changed the title
danielporterda
requested review from
da-tanabe,
hrischuk-da,
miller-da and
shreyas-da
October 30, 2026 14:39
shreyas-da
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes the scheduled generated-docs workflow, broken since Canton 3.7 made
protoVersionForreturn anEither. The topology version table now comes from the highest Canton release rather than the most recently published one, keeps earlier rows as releases ship, and drops Canton's alpha placeholder protocol version.