Repository navigation
chore: Simplify MTX Sidecar Client - #47
Merged
Merged
Conversation
![hyperspace-pr-bot[bot]](https://avatars.githubusercontent.com/u/2531208?s=60&v=4){kind=small}
There was a problem hiding this comment.
The byte-preserving transport change is internally consistent, but it introduces a breaking change to a published public interface. Please preserve compatibility or treat and document it as a major-version API change.
PR Bot Information
Version: 1.33.12
- File Content Strategy: Full file content
- Event Trigger:
pull_request.opened - LLM:
gpt-5.6-sol - Correlation ID:
e2d5cf90-ce98-11f1-9adf-0568fc37c0f1
InaGlushkova
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Return Binary Responses from the MTX Sidecar Client
Refactor
♻️ Simplified ORD resource handling by returning raw byte arrays from the MTX sidecar client, avoiding unnecessary UTF-8 string conversions before creating input streams.
Changes
MtxSidecarClient.java: Updated ORD document and resource definition methods to returnbyte[].MtxSidecarClientImpl.java: Reads successful HTTP response bodies directly into byte arrays.DynamicOrdResourcesProviderImpl.java: Creates input streams directly from sidecar response bytes.MtxSidecarClientImplTest.java: Updated client tests to validate binary responses with array assertions.DynamicOrdResourcesProviderImplTest.java: Updated sidecar mocks to return byte arrays for ORD resources.PR Bot Information
Version:
1.33.12e2d5cf90-ce98-11f1-9adf-0568fc37c0f1pull_request.openedgpt-5.6-sol