Repository navigation
chore: Improve Utils.Streams.asStream and Utils.Streams.asList - #48
Merged
Merged
Conversation
![hyperspace-pr-bot[bot]](https://avatars.githubusercontent.com/u/2531208?s=60&v=4){kind=small}
There was a problem hiding this comment.
No substantive correctness or maintainability issues found in the changes. The null handling is consistent and covered by tests.
PR Bot Information
Version: 1.33.12
- Correlation ID:
a7bb63b0-ce99-11f1-93ec-0d8a9d529e92 - File Content Strategy: Full file content
- LLM:
gpt-5.6-sol - Event Trigger:
pull_request.opened
InaGlushkova
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle Null Inputs in Stream Utilities
Bug Fix
🐛 Updated the ORD stream utilities to handle null inputs safely.
asStreamandasListnow return empty results instead of throwing aNullPointerException, while preserving existing behavior for non-null inputs.Changes
cds-feature-ord/src/main/java/com/sap/cds/feature/ord/common/Utils.java: Added null checks soStreams.asStream(null)returns an empty stream andStreams.asList(null)returns an empty immutable list.cds-feature-ord/src/test/java/com/sap/cds/feature/ord/common/UtilsTest.java: Added test coverage for null inputs to both stream conversion utilities.PR Bot Information
Version:
1.33.12gpt-5.6-sola7bb63b0-ce99-11f1-93ec-0d8a9d529e92pull_request.opened