Repository navigation
Conversation
daogrady
force-pushed
the
fix/rest-collection-response-shape
branch
from
October 14, 2026 08:45
1b98fd7 to
88fb2e6
Compare
CAP REST returns two distinct shapes depending on $count: a bare array
without it, or {count, value} with it. OpenAPI cannot condition a
response schema on a query parameter value, so document both via oneOf.
Also fixes the count property name for REST (count, not @count) and
aligns nav-property expansion count with the OData fix (@odata.count).
daogrady
force-pushed
the
fix/rest-collection-response-shape
branch
from
October 14, 2026 09:00
88fb2e6 to
d51ddc3
Compare
daogrady
marked this pull request as ready for review
October 16, 2026 12:28
tim-sh
reviewed
Oct 16, 2026
tim-sh
left a comment
tim-sh
left a comment
Member
There was a problem hiding this comment.
Should look good if the conflict resolution leaves only the REST oneOf change, which is the actual goal here.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(partially) fixes CS20260013358977
specifically:
CAP REST returns two distinct shapes depending on
$count: a bare array without it, or{count, value}with it. OpenAPI cannot condition a response schema on a query parameter value, so document both viaoneOf.This behaviour was confirmed to be working as intended by @vkozyura.