refactor(port): migrate to units::temperature based body temperature - #9131
Open
scarf005 wants to merge 2 commits into
Open
refactor(port): migrate to units::temperature based body temperature#9131scarf005 wants to merge 2 commits into
units::temperature based body temperature#9131scarf005 wants to merge 2 commits into
Conversation
units::temperature based body temperature
scarf005
force-pushed
the
refactor/body-temperature-units
branch
from
June 5, 2026 14:23
6c92d5f to
c67f870
Compare
scarf005
force-pushed
the
refactor/body-temperature-units
branch
from
June 17, 2026 02:29
c67f870 to
071f386
Compare
scarf005
marked this pull request as ready for review
June 17, 2026 02:29
scarf005
force-pushed
the
refactor/body-temperature-units
branch
from
June 18, 2026 14:28
a626470 to
aca83de
Compare
scarf005
marked this pull request as draft
June 26, 2026 01:08
scarf005
force-pushed
the
refactor/body-temperature-units
branch
3 times, most recently
from
July 2, 2026 12:36
072a699 to
0cd4ee9
Compare
scarf005
force-pushed
the
refactor/body-temperature-units
branch
from
July 2, 2026 15:28
566507e to
108755c
Compare
scarf005
marked this pull request as ready for review
July 2, 2026 15:34
units::temperature based body temperatureunits::temperature based body temperature
Port CleverRaven/Cataclysm-DDA#68796. Co-authored-by: prharvey <2677507+prharvey@users.noreply.github.com> Assisted-by: pi:gpt-5.5 Co-authored-by: chatgpt-codex-connector[bot] <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com>
scarf005
force-pushed
the
refactor/body-temperature-units
branch
from
July 8, 2026 04:51
108755c to
6b5b125
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of change (The Why)
units::temperature/units::temperature_deltarelated: #2570, #397, #1417
Describe the solution (The How)
src/units/*_btuLua bindings and added Celsius bindingsintmillidegree Celsius units internallyTesting
playtested for a bit, bodytemps seems to work as intended, e.g getting cold or warm
Checklist
Mandatory
closes #1234in Summary of the PR so it can be closed automatically.Optional
Assisted-by:trailer to every AI-assisted commit in the Linux kernel format.portscope to the PR title.Co-Authored-Byin the commit message.docs/folder.lang/bn_extract_json_strings.shscript if it does not support them yet.luascope to the PR title.PR opened by gpt-5.5 high on pi
Build Artifacts
PR build for commit 1f2468b (Merge branch 'main' into refactor/body-temperature-units) on 2026-07-24 01:52:41