Repository navigation
test: cover client canonical metadata after hydration - #197
Open
Vamsi-2581 wants to merge 1 commit into
Open
Vamsi-2581 wants to merge 1 commit into
Vamsi-2581 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add focused coverage for the generated client metadata behavior introduced in #194. The test executes the generated script with node:vm, simulates Notion rewriting canonical, og:url, and twitter:url tags, and verifies that the worker restores the canonical URL for the home page, a mapped slug, and an unmapped page ID. It includes duplicate tags and exercises observer callbacks after navigation, so the former worker-only MY_DOMAIN reference in the client script would fail the test.
This separate regression-test follow-up was invited by the maintainer on #195 after the behavior fix merged in #194.
Validation
AI assistance
Prepared with OpenAI Codex assistance.