Repository navigation
Conversation
find_gauge_ids() parses the full id from gaugeNNNNN.txt (Fortran writes I0.5, so ids can exceed 5 digits) and skips non-gauge files; compare_gauges raises a clear error for fields missing from either run. Adds tests. Signed-off-by: Kyle Mandli <kyle.mandli@gmail.com> Assisted-by: claude claude-opus-5-5
|
coverage: 49.485% (+2.4%) from 47.079% — mandli:fix-gauge-cli-ids into clawpack:master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
There was a latent bug when the CLI code for gauges parsed gauge IDs from file names. Also skips non-gauge files (it was using a simple glob before) and if the fields do not match raises an exception. Also adds a couple of suggested tests.
Assisted-by: claude claude-opus-5-5