Repository navigation
#45 - Throw exceptions implementing ProcessExceptionInterface instead of raw SPL exceptions - #46
Merged
Merged
Conversation
… of raw SPL exceptions As cleverage/process-bundle#317: new exceptions of the bundle extending the SPL exceptions thrown before and implementing ProcessExceptionInterface (11 throw replaced, same messages). Tests and CHANGELOG updated. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #45, as cleverage/process-bundle#317 (PR cleverage/process-bundle#321).
Exception/, extending the SPL exceptions thrown until now and implementingCleverAge\ProcessBundle\Exception\ProcessExceptionInterface(available since process-bundle 4.0, asMissingClientExceptionof soap):Exception\UnexpectedValueException,Exception\RuntimeException.throw new \<SPL exception>ofsrc/use them: same messages and codes. The exceptions of the Symfony components are not concerned.Tests:
SplExceptionsTest(each exception extends its SPL class and implements the interface). The existing tests pass unchanged.Checked in the container (PHP 8.5, highest dependencies): 36 tests, 96 % of the lines, no risky test (pcov coverage). PHPStan, PHP-CS-Fixer and Rector OK.
Requirements
Breaking changes
None: the new exceptions extend the classes thrown until now, the existing
catchkeep working.🤖 Generated with Claude Code