Repository navigation
#57 - Mark the classes not meant to be extended @final and the infrastructure classes @internal - #60
Merged
Merged
Conversation
…tructure classes @internal - @Final since 3.3 (final in 4.0): the concrete tasks (DatabaseReaderTask, DatabaseUpdaterTask, DoctrineReaderTask, DoctrineWriterTask, DoctrineBatchWriterTask, DoctrineCleanerTask, DoctrineDetacherTask, DoctrineRefresherTask, DoctrineRemoverTask, ClearEntityManagerTask) and CleverAgeDoctrineProcessBundle. Extending them triggers a deprecation with the Symfony DebugClassLoader. - Stay open: AbstractDoctrineTask and AbstractDoctrineQueryTask. - @internal: CleverAgeDoctrineProcessExtension. - Tests of DatabaseReaderTask, DatabaseUpdaterTask and DoctrineReaderTask no longer extend the tasks with anonymous classes: the options are given by the mocked ProcessState (getContextualizedOptions()) and the connection by the ManagerRegistry stub, so the real option resolution and getConnection() are tested. - Same model as cleverage/process-bundle#279. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
njoubert-cleverage
force-pushed
the
57
branch
from
October 19, 2026 10:18
e6280d4 to
52d9f5f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #57. Same model as cleverage/process-bundle#279: annotations only, so that the classes not meant to be extended can become
finalin 4.0.@final since 3.3(finalin 4.0): the concrete tasks (DatabaseReaderTask,DatabaseUpdaterTask,DoctrineReaderTask,DoctrineWriterTask,DoctrineBatchWriterTask,DoctrineCleanerTask,DoctrineDetacherTask,DoctrineRefresherTask,DoctrineRemoverTask,ClearEntityManagerTask) andCleverAgeDoctrineProcessBundle. Extending them triggers a deprecation with the SymfonyDebugClassLoader.AbstractDoctrineTaskandAbstractDoctrineQueryTask.@internal:CleverAgeDoctrineProcessExtension.DatabaseReaderTaskTest,DatabaseUpdaterTaskTestandDoctrineReaderTaskTestextended the tasks with anonymous classes (16 tests) to inject the options and the connection, which PHPStan rejects once the tasks are@final(and which would fail in 4.0). They now build the real task: the options are returned by the mockedProcessState::getContextualizedOptions()and the connection by theManagerRegistrystub, so the option resolution andgetConnection()are tested too (line coverage 286/286).Checked in the container (
composer update, PHP 8.5): PHPUnit with pcov, PHPStan, PHP-CS-Fixer and Rector OK.Requirements
Breaking changes
None in 3.3: annotations only (extending a
@finalclass triggers a deprecation). Major (4.0): the@finalclasses becomefinal, the@internalclasses are not covered by the BC promise.🤖 Generated with Claude Code