Repository navigation
#89 - Tag a Symfony cache pool directly as the memory cache adapter, remove MemoryAdapter - #90
Merged
Merged
Conversation
…remove MemoryAdapter The memory cache adapter is an array cache pool (parent: cache.adapter.array) tagged cleverage.cache.adapter, wrapped in an Adapter by the cache bundle (cleverage/cache-process-bundle#67): App\Adapter\MemoryAdapter is removed. Requires the next cache-process-bundle minor. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #89, after cleverage/cache-process-bundle#67 (PR cleverage/cache-process-bundle#68): a Symfony cache pool can be tagged
cleverage.cache.adapterdirectly.config/services.yaml: thememoryadapter is now an array cache pool,app.cache.memory(parent: cache.adapter.array, tagscache.poolandcleverage.cache.adapterwith the codememory), wrapped in anAdapterby the bundle. Same behaviour as before (ArrayAdapter, no default lifetime, values serialized).src/Adapter/MemoryAdapter.phpremoved..claude/CLAUDE.md: points to the pool instead of the removed class.Draft until the release: with cache-process-bundle 2.2 (the version of
composer.lock), a pool tagged directly fails (it does not implement the bundle'sAdapterInterface). Once the next cache minor is released, require it in this PR and updatecomposer.lock.Checks (
vendor/cleverage/cache-process-bundleonmain,4056d87)lint:containerOK;.cleverage_cache_process.adapter.memoryis anAdapteraroundapp.cache.memory.demo.cache.set_get,demo.cache.get_on_miss,demo.cache.set_expires_afteranddemo.transformers_edge.cachedsucceed;demo.cache.get_invalid_input,demo.cache.set_invalid_input_optionanddemo.cache.set_invalid_keyfail as designed.Requirements
Breaking changes
None.
🤖 Generated with Claude Code