[njoubert-cleverage]

Description

Fixes #307. Reproduction: demo processes demo.blocking.* and demo.input_aggregator.* (cleverage/process-bundle-demo#88).

The fix

• ProcessState: new getExecutionCount() (number of executions of the task: execute, proceed or flush, not reset between the items) and @internal incrementExecutionCount(), called by ProcessManager::processExecution() before each execution.
• InputAggregatorTask records, for each received input, the execution count of its ancestors (getPreviousState() chain). When an input arrives, the inputs received from the other branches are dropped if a common ancestor has been executed again since: they belong to a previous item that a branch skipped. Unchanged:
  • the inputs of keep_inputs are never dropped;
  • an input received twice from the same branch keeps the clean_input_on_override behaviour;
  • inputs without a common ancestor are always joined.

demo.input_aggregator.skipped_branch (branch_a skips the item 2, branch_b the item 4):

	Outputs
Before	{"a":"a1","b":"b1"}, {"b":"b2","a":"a3"}, {"b":"b3","a":"a4"}, {"a":"a5","b":"b5"}
After	{"a":"a1","b":"b1"}, {"a":"a3","b":"b3"}, {"a":"a5","b":"b5"}

Deprecation removed

• InputAggregatorTask: constructor with trigger_deprecation() (Bundle best practices: residues (generic transformers autowiring, help command container, deprecation notices) #305, not released), @deprecated (2018) and the @see README.md:Known issues pointing to a removed section. The limits of the blocking tasks given as the reason no longer exist (InputAggregatorTask: remove the deprecation, fix the items mixed when a branch skips one #307), and a blocking task is not a replacement (it outputs once for all the items). Marked @final since 5.4, like the other concrete tasks (Define the public API: mark classes final or internal #279).
• Reference page (no more Deprecated, Notes rewritten, example in an iterable process), good practices page (mentioned again for the dependencies between branches), CHANGELOG (entry of Bundle best practices: residues (generic transformers autowiring, help command container, deprecation notices) #305 corrected), KernelTest (no more ignored deprecation).
• v6.0: remove the deprecated code #292 (v6.0 removals) updated: the item is removed.

Tests

• InputAggregatorTaskTest: deprecation test removed; new tests with a common ancestor: item skipped by the first branch, by the last branch, keep_inputs, no common ancestor.
• KernelTest::testInputAggregatorDropsTheItemsSkippedByABranch(): the processes run by the ProcessManager (filter in both branches, error with error_strategy: skip). Both fail without the fix (checked).

Checked in the container (977 tests): highest dependencies (PHP 8.5, Symfony 8.1), lowest dependencies (PHP 8.2, Symfony 6.4.0), Symfony 6.4.48 on PHP 8.2 and 8.5, Symfony 7.4: no deprecation, no risky test (with pcov coverage). PHPStan, PHP-CS-Fixer and Rector OK. Demo processes run with this branch: demo.input_aggregator.skipped_branch gives the expected output, the 4 others are unchanged.

Requirements

• Documentation updates
  • Reference
  • Cookbooks
  • Changelog
• Unit tests

Breaking changes

None. The deprecation removed was never released. Only the outputs that were wrong change: the inputs of an item skipped by a branch are dropped instead of being joined with the next item.

🤖 Generated with Claude Code