Skip to content

test(system-settings): drop guard metadata specs - #2810

Merged
shikanime merged 2 commits into
mainfrom
cleanup/guard-metadata-specs
Oct 19, 2026
Merged

test(system-settings): drop guard metadata specs#2810
shikanime merged 2 commits into
mainfrom
cleanup/guard-metadata-specs

Conversation

@shikanime

@shikanime shikanime commented Oct 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Pourquoi

system-settings.controller.spec.ts porte deux specs de metadata (Reflect.getMetadata sur __guards__ et ADMIN_PERMISSIONS_KEY), introduites par 7bf630f9 avec le fix ManageSystem. La famille de migration a depuis convergé sur la règle « pas de specs de guard par metadata » (stage 3cdad972/4f404cc0, zone 1c9a359e, user dfbb3cff) ; main reste le seul porteur.

Quoi

  • Les deux specs metadata sont retirées.
  • L'import UserGuard reste pour l'overrideGuard du beforeEach.
  • La visibilité des guards se lit dans le code du contrôleur ; une preuve HTTP avec persona reste la forme admise si exigée.
  • Aucun breaking change : tests uniquement, aucun changement de production.
  • npx vitest run src/modules/system-settings/ — 6 tests verts.

Références

Related: #2863
#2863

@shikanime
shikanime requested a review from a team as a code owner October 2, 2026 14:08
@github-actions github-actions Bot added the built label Oct 2, 2026
@shikanime
shikanime marked this pull request as draft October 2, 2026 14:17
StephaneTrebel
StephaneTrebel previously requested changes Oct 5, 2026
View reviewed changes

@StephaneTrebel StephaneTrebel left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blocking: cette MR n’est liée à aucune issue, alors que le processus impose un ticket et son ledger de définition du fini. L’allègement des tests est cohérent avec la convention citée, mais il faut lier ou créer l’issue avant intégration.

@shikanime shikanime self-assigned this Oct 8, 2026
@shikanime
shikanime marked this pull request as ready for review October 8, 2026 12:25
@shikanime
shikanime force-pushed the cleanup/guard-metadata-specs branch from 2fdf346 to 4988f6a Compare October 8, 2026 12:25
@shikanime
shikanime marked this pull request as draft October 8, 2026 12:25
@shikanime

shikanime commented Oct 15, 2026

Copy link
Copy Markdown
Member Author

RFC ouverte pour généraliser ce mouvement : la couverture IAM (401/403) ne devrait pas être retestée dans chaque spec de contrôleur — discussion #2863.

@shikanime shikanime added this to the 10.0.0 milestone Oct 15, 2026
@shikanime shikanime added the technical debt Résoud de la dette technique label Oct 15, 2026
@shikanime
shikanime marked this pull request as ready for review October 15, 2026 13:03
@shikanime
shikanime enabled auto-merge October 15, 2026 13:15
StephaneTrebel
StephaneTrebel approved these changes Oct 16, 2026
View reviewed changes

@StephaneTrebel StephaneTrebel left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Le diff retire uniquement les deux assertions de metadata et ne modifie pas le comportement de production ; les tests CI sont verts. Pas d’issue liée avec ledger dans la PR : sans ledger.

@shikanime
shikanime disabled auto-merge October 16, 2026 09:28
@shikanime
shikanime enabled auto-merge October 16, 2026 09:28
@StephaneTrebel StephaneTrebel mentioned this pull request Oct 17, 2026
Open
4 tasks
@shikanime
shikanime disabled auto-merge October 19, 2026 08:24
@shikanime
shikanime enabled auto-merge October 19, 2026 08:24
@shikanime
test(system-settings): drop guard metadata specs
652536d 
Co-authored-by: Automata <automata@shikanime.studio>
Signed-off-by: William Phetsinorath <william.phetsinorath-open@interieur.gouv.fr>
Change-Id: Icdb008ed4297161477f560fcc41777ec6a6a6964

Signed-off-by: Shikanime Deva <22115108+shikanime@users.noreply.github.com>
@shikanime
fix(system-settings): restore UserGuard import for overrideGuard
a149d8f 
Co-authored-by: Automata <automata@shikanime.studio>
Signed-off-by: William Phetsinorath <william.phetsinorath-open@interieur.gouv.fr>
Change-Id: I52bf7b39f7d7ab925e1e62bee8aae86b6a6a6964

Signed-off-by: Shikanime Deva <22115108+shikanime@users.noreply.github.com>
@shikanime
shikanime force-pushed the cleanup/guard-metadata-specs branch from 4988f6a to a149d8f Compare October 19, 2026 08:43
@shikanime
shikanime disabled auto-merge October 19, 2026 08:47
@shikanime
shikanime enabled auto-merge October 19, 2026 08:47
@cloud-pi-native-sonarqube

cloud-pi-native-sonarqube Bot commented Oct 19, 2026

Copy link
Copy Markdown

Passed Quality Gate passed

Issues

Measures

Project ID: cloud-pi-native_console_AYsa46O31ebDtzs-pYyZ

View in SonarQube

@shikanime
shikanime disabled auto-merge October 19, 2026 08:59
@shikanime
shikanime added this pull request to the merge queue Oct 19, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 19, 2026
@iliesmrf iliesmrf modified the milestones: 10.0.0, 9.28.0 Oct 19, 2026
@shikanime
shikanime added this pull request to the merge queue Oct 19, 2026
Merged via the queue into main with commit 219939c Oct 19, 2026
34 checks passed
@shikanime
shikanime deleted the cleanup/guard-metadata-specs branch October 19, 2026 12:38
@github-project-automation github-project-automation Bot moved this from Refinement to Done in Cloud Pi Native Oct 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StephaneTrebel StephaneTrebel StephaneTrebel approved these changes

Assignees

@shikanime shikanime

Labels

built technical debt Résoud de la dette technique

Projects

None yet

Milestone

9.28.0

Development

Successfully merging this pull request may close these issues.

3 participants

@shikanime @StephaneTrebel @iliesmrf