Skip to content

Fix AlwaysListMatcher behavior - #206

Open
sean0407 wants to merge 1 commit into
cloudflare:masterfrom
sean0407:codex/wirefilter-190-always-list-20261020
Open

sean0407 wants to merge 1 commit into
cloudflare:masterfrom
sean0407:codex/wirefilter-190-always-list-20261020

Conversation

@sean0407

Copy link
Copy Markdown

Summary

  • Make AlwaysListMatcher match every value, as its documented contract requires.
  • Add a regression test that builds and executes num in $numbers through the public API.

Evidence

  • Before the fix, the regression test failed: the filter returned Ok(false) instead of Ok(true).
  • Checks run: cargo test --offline --locked -p wirefilter-engine (152 unit tests and 2 doctests passed); git diff --check passed; patch policy accepted 2 files and 18 changed lines with no binary changes.

Fixes #190

Merge Danger

Door: two-way

Blast Radius: localized

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AlwaysListMatcher::match_value always returns false, contradicting its own doc comment

1 participant