Repository navigation
fix: Don't drop work queued by the last active table in shuffle-queue - #2633
Merged
Merged
Conversation
erezrokah
approved these changes
Oct 15, 2026
erezrokah
left a comment
Member
There was a problem hiding this comment.
LGTM, no blockers. The buffered workDone signal cannot lose a Done, and the second Pop catches relations that the last active table queued.
Follow-ups, not blockers:
- The dispatcher wakes only on
Done, not onPush. Relations from a long-running table wait until a worker finishes. APushsignal also removes the need for the secondPop. isStartedis not necessary now. It can also makedispatchblock forever if the queue starts empty.Waitdoes not usectx. Considerselectonctx.Done().
Member
Author
|
@erezrokah thanks, all three are handled in 940549b.
The tests in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The shuffle-queue dispatcher now gets work from a
workQueuethat pops and checks for idle under one lock, and wakes onPush,Doneor context cancel.