Skip to content

Fix PrometheusExporter double counting questions - #1703

Merged
Virv12 merged 1 commit into
cms-dev:mainfrom
Virv12:fix-questions
Aug 10, 2026
Merged

Fix PrometheusExporter double counting questions#1703
Virv12 merged 1 commit into
cms-dev:mainfrom
Virv12:fix-questions

Conversation

@Virv12

@Virv12 Virv12 commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

In cms some questions can be both answered and ignored at the same time, this made PrometheusExporter double count them.

@codecov

codecov Bot commented Aug 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 53.89%. Comparing base (b4da278) to head (01b3493).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1703   +/-   ##
=======================================
  Coverage   53.89%   53.89%           
=======================================
  Files         341      341           
  Lines       27985    27985           
=======================================
  Hits        15083    15083           
  Misses      12902    12902           
Flag Coverage Δ
functionaltests 0.00% <ø> (ø)
unittests 53.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Virv12
Virv12 merged commit e586c7f into cms-dev:main Aug 10, 2026
4 checks passed
@Virv12
Virv12 deleted the fix-questions branch August 10, 2026 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants