Allow adding organisers during workshop creation - #2802
Open
mroderick wants to merge 1 commit into
Open
Conversation
mroderick
force-pushed
the
feature/allow-adding-organisers-during-workshop-creation
branch
from
August 9, 2026 20:50
98637ca to
9e01b76
Compare
mroderick
marked this pull request as ready for review
August 9, 2026 20:54
Contributor
|
@mroderick What happens when someone is an organiser of multiple chapters? |
Collaborator
Author
The adjusted version is only visible, if you use the "New workshop" button on a chapter's admin page (as that's how we know which chapter you want). If you initiate the creation from the dropdown menu, then you will see the regular UI, where you can choose the chapter (because we don't have the chapter context). So, it should work seamlessly for folks that organise multiple chapters. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2398.
When creating a workshop from a chapter admin page, the chapter is now pre-selected, the chapter dropdown is hidden, and the chapter's organisers are shown as pre-selected but editable. The page heading and browser title also reflect the selected chapter.
Changes
chapter_idfrom the chapter show page's "New workshop" link.Admin::WorkshopsController#newwhen a validchapter_idis provided.chapter_idfield so a failed create re-renders with the chapter still selected.chapter_idfallback.How to verify
bundle exec rails server) and sign in as an admin or chapter organiser./admin/chapters/<chapter-id>)./admin/workshops/newdirectly (without achapter_id) and confirm the heading is New Workshop, the Chapter dropdown is visible, and there is no Organisers input.make test.Verification
bundle exec rspec spec/features/admin/workshops_spec.rbpasses.bundle exec rspec spec/controllers/admin/workshops_controller_spec.rbpasses.bundle exec rubocoppasses for the changed Ruby files.bundle exec haml-lintpasses for the changed HAML files.make testpasses (1226 examples, 0 failures).