Repository navigation
Self-assembly infers capabilities from the registry, not a hardcoded list (#44) - #65
Open
minerva-sky wants to merge 2 commits into
Open
minerva-sky wants to merge 2 commits into
minerva-sky wants to merge 2 commits into
Conversation
…list AgentAssemblyEngine#infer_capabilities_from_description matched task text against a literal list of 11 names. Only 4 of the 7 built-in capabilities were on it, 7 of the 11 names were never registered, and the list said structure_extraction where the registry says structured_extraction. Any capability a downstream gem registered could never be inferred. The candidates are now registry.list.keys, which is how the LLM-assisted strategy already works. DefaultCompositionStrategy also stops selecting a capability twice when it is both a requirement and an earlier requirement's dependency. Closes codenamev#44 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
With the candidate set now the whole registry, a two-letter name such as "db" or "ai" must not match inside "feedback" or "maintain". The literal, space-separated, and stem forms all require a word boundary now. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #44.
AgentAssemblyEngine#infer_capabilities_from_descriptionmatched task text against a literal list of 11 names. Only 4 of the 7 built-in capabilities were on it, 7 of the 11 names were never registered, and the list saidstructure_extractionwhere the registry saysstructured_extraction. A capability a downstream gem registered could never be inferred by the default (non-LLM) strategy, which is the oneAgentic.assemble_agentandagentic agent buildship with.What changes
@registry.list.each_key, which is howLlmAssistedCompositionStrategyalready works. The literal array is gone.dbno longer fires on "feedback",aino longer fires on "maintain". The literal, space-separated, and stem forms all require\bnow.DefaultCompositionStrategy#select_capabilitiesskipped a dependency that was already selected but not a top-level requirement that an earlier dependency had already pulled in, sotext_generationlanded twice for "Analyze the data and generate code". Guarded.No public signature changes. Assembled-agent output changes for descriptions that mention a registered capability, which is the point; CHANGELOG entry under Changed.
Tests
7 new examples in
spec/agentic/agent_assembly_engine_spec.rb: the four descriptions from the issue selectsummarization,brainstorming,structured_extraction, and a spec-registeredinvoice_parsing; unregistered names (uml_generation,dependency_analysis) are never inferred; empty registry degrades totext_generation; word-boundary negative and positive cases; dedupe. Full suite: 1397 examples, 1 failure, theevent_dispatcher_integration_spec.rb:291timing flake that #36 addresses.Touches the same file as #53 but different regions (that PR seeds planned capabilities above the inference call; this one changes the inference body), so they should merge in either order.
Panel
each_keyinstead ofkeys.each. Verified the comment's claim that the LLM strategy readsregistry.list(llm_assisted_composition_strategy.rb:23).build_agentonly callsadd_capability; nothing in lib/ dispatches a capability from LLM output, a consumer callsexecute_capabilityexplicitly), and the LLM strategy and the explicitinput[:capabilities]path already accept any registered name. Re-run 2/3 cleared; the dissent wants an importance floor on stem matches, which I'd take as a follow-up if a tool-calling loop ever lands.listis an in-memory walk over under ten entries, called up to four times per analysis; not worth hoisting.🤖 Generated with Claude Code