Repository navigation
docs: add REVIEW.md, the repo-local review prior - #79
Open
minerva-sky wants to merge 1 commit into
Open
minerva-sky wants to merge 1 commit into
minerva-sky wants to merge 1 commit into
Conversation
Six failure shapes this repo has actually had (sanitizer drift, secrets on disk, workspace escapes, dev-bundle-only loads, one-Ruby green, documented-but-unwired), a path:line evidence rule, a three-nit cap, and the paths a reviewer skips. Same shape as ai-software-architect #129. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One short file at the repo root that tells a reviewer (human, panel seat, or an agent on a tick) what a bad merge looks like in this repo, before they read the diff.
Six failure shapes, each grounded in an issue or PR this repo has already had:
require "agentic"(lib/agentic.rb forbids require_relative between siblings; 61 lines in 27 files do it anyway, all reintroduced by #7 #57,require "agentic"can't load ArtifactGraph or AuthenticationSystem outside the dev bundle: rgl and base64 are required by lib/ but declared nowhere a consumer sees #63, fix: ArtifactGraph on stdlib TSort; declare every runtime dependency lib/ requires #74, Load lib/agentic through Zeitwerk alone; drop 57 require_relative lines, add loader spec #78)Plus a
path:lineevidence rule, a three-nit cap, and the skip paths (CHANGELOG, lockfile, coverage and run artifacts, examples).Same shape as codenamev/ai-software-architect#129. Docs only, no code or CI change. Edit anything that reads wrong; the file is the point, not my wording of it.
🤖 Generated with Claude Code